[RSPEED-175] Rework config file handler and history #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r0x0d
changed the title
samdoran
reviewed
Oct 18, 2024
r0x0d
force-pushed
the
rework-config-files
branch
2 times, most recently
from
e6768aa to
f221152
Compare
abadger
reviewed
Oct 21, 2024
abadger
reviewed
Oct 21, 2024
abadger
reviewed
Oct 22, 2024
abadger
reviewed
Oct 22, 2024
abadger
reviewed
Oct 22, 2024
abadger
reviewed
Oct 22, 2024
abadger
reviewed
Oct 22, 2024
|
Thanks for the review, @abadger! I will get to this as soon as possible. |
r0x0d
force-pushed
the
rework-config-files
branch
from
f221152 to
16a7e0e
Compare
Introduced two new modules, one for handling code related to config files The second, to handle history where we read and append to new history. Dropped the support for pypyaml as well. We will move on with tomllib
r0x0d
force-pushed
the
rework-config-files
branch
from
16a7e0e to
56bedc3
Compare
|
We have requested the Please confirm the request on the @rhel-lightspeed/command-line-assistant Copr project permissions page and retrigger the build by clicking on a |
|
/packit build |
r0x0d
force-pushed
the
rework-config-files
branch
4 times, most recently
from
91515c2 to
c98398f
Compare
pr-watson
reviewed
Oct 29, 2024
r0x0d
force-pushed
the
rework-config-files
branch
from
c98398f to
ae44752
Compare
Co-authored-by: Preston Watson <prwatson@redhat.com>
pr-watson
approved these changes
Oct 29, 2024
pr-watson
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced two new modules, one for handling code related to config files The second, to handle history where we read and append to new history. Dropped the support for pypyaml as well. We will move on with tomllib