Fix returncode when running commands (#116)

rhel-lightspeed · Jan 16, 2025 · 449f6f2 · 449f6f2
1 parent 7b3e4be
commit 449f6f2
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/command_line_assistant/initialize.py b/command_line_assistant/initialize.py
@@ -59,5 +59,4 @@ def initialize() -> int:
         return 1
 
     service = args.func(args)
-    service.run()
-    return 0
+    return service.run()
diff --git a/packaging/command-line-assistant.spec b/packaging/command-line-assistant.spec
@@ -111,6 +111,7 @@ LICENSE
 
 %changelog
 * Wed Jan 22 2025 Rodolfo Olivieri <rolivier@redhat.com> 0.2.0
+- Fix returncode when running commands
 - Refactor the CLI to be separate commands
 - Add an experimental rendering module for client
 - Add Command Line Assistant Daemon

diff --git a/tests/test_initialize.py b/tests/test_initialize.py
@@ -49,7 +49,7 @@ def test_initialize_with_query_command(argv, stdin):
         mock_parse.return_value.func = mock_command
         result = initialize()
 
-        assert result == 0
+        assert result == 1
         mock_command.assert_called_once()
 
 
@@ -67,7 +67,7 @@ def test_initialize_with_history_command():
         mock_parse.return_value.func = mock_command
         result = initialize()
 
-        assert result == 0
+        assert result == 1
         mock_command.assert_called_once()
 
 
@@ -136,5 +136,5 @@ def test_initialize_command_selection(argv, expected_command):
 
         result = initialize()
 
-        assert result == 0
+        assert result == 1
         mock_command.assert_called_once()