Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix load option regression #380

Closed
wants to merge 2 commits into from
Closed

Fix load option regression #380

wants to merge 2 commits into from

Commits on Jun 8, 2021

  1. Revert "Fix a plausible NULL dereference." 

    This reverts commit 9e8dde5. A
fix for the actual NULL pointer, to turn `cur = li->LoadOptions`
into `cur = start = li->LoadOptions` is in the next patch.

Bug-Ubuntu: https://bugs.launchpad.net/bugs/1929471
    @julian-klode
    julian-klode committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    dfceaa3 View commit details
    Browse the repository at this point in the history

  2. shim: Correctly initialize start variable in load option parsing 

    This variable was not initialized, but the fix in
9e8dde5 was wrong, so after
reverting it, just initialize the variable like in the `if` path
above it.

An alternative is to check for `start == NULL` inside the if below
this, instead of, or in addition to `start == li->LoadOptions`.
    @julian-klode
    julian-klode committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    8175449 View commit details
    Browse the repository at this point in the history