-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added devDependencies block to bower.json configuration #93
Conversation
Nice feature! How does bower know when to install the devDependencies and when not to? |
@1st8 Do we need it to be installed in production? |
No we don't, sorry if that was unclear. I would say devDependencies MUST NOT be installed in production. I just couldn't find any bower related flag to tell it NOT to install the devDependencies in production. |
There is the |
What do you think about using this flag in the |
We can do that now by But is it the preferred behavior? I don't think so. That's why now by default we have On subject: if we have |
I'm planning to use I think this is the main use case of a deployment-install, just like So for me it would be a perfect fit to instruct bower not to install development dependencies by default in a deployment install, but setting the Back to topic - devDependencies are definitely a nice addition which I can see myself using in the future. |
@ValMilkevich, great work! But before merge we have to:
@1st8 any contributions are welcome, "Versioning, deployment and dependency conflict" would be very useful for current version. |
@SergeyKishenin, thanks for the note, I'm going to amend those during the upcoming few days. |
@SergeyKishenin, @1st8 please check it out, PR looks ready for me |
For me too. But there are some conflicts right now, are you gonna fix it? |
Looks like it's just not possible to merge with master, I thought it's something you can do when accepting PR? I'm pretty new with public PRs, how can I resolve the conflicts? |
it can be that github is just tricking around, as there are no conflicts in the branch ( however I forced push after squashing the commits - may it be the reason? ) |
No description provided.