Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding bowerify gem to fix the issue with relative assets paths in bower components #85

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kaievns
Copy link

@kaievns kaievns commented May 10, 2014

hey guys, there is a little gem called bowerify that fixes the relative assets path when you use bower components in rails assets pipeline.

@SergeyKishenin
Copy link
Collaborator

Have you tested it with bower-rails? Does it work correctly out of the box?

If yes, do we need resolving stuff anymore, like rake tasks, resolving before precompilation and so on?

@kaievns
Copy link
Author

kaievns commented May 10, 2014

Hey Sergey,

I didn't test it much with bower-rails, but I did tested the bowerify code quite extensively everything seems working just fine. As there is not much of overlap between the two, i figured it should be alright.

as for your resolving tasks, i believe you won't need them anymore, assets precompilation works perfectly with bowerify in my project (i have bootstrap3 and font-awesome) assets get copied and hashed correctly. But again, i didn't test it with bower-rails as i'm not really a user (i'm on vanilla bower)

@SergeyKishenin
Copy link
Collaborator

Okay, thanks! So we have to test it first before merge. I'll try to do it asap

@kaievns
Copy link
Author

kaievns commented May 10, 2014

no worries, let me know how did it go. btw, you might wanna create a simple demo project for the gem, so people could test their changes over it properly.

@eddietejeda
Copy link

What's the status of this pull request?

@SergeyKishenin
Copy link
Collaborator

I've tried to go on working on it but met an issue ninefold/bowerify#2.

Actually, I prefer to implement our own (or extract some logic out of bowerify if it is possible) to close this issue. But now I have lack of time to achieve it.

So, if anyone can help with that — welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants