Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rhai shared scoped refs #901

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

mrazorvin
Copy link

No description provided.

@schungx
Copy link
Collaborator

schungx commented Jul 17, 2024

A couple of quick observations:

  • Try not to change existing API like register_get or else we'll break code. Better to add to the API surface instead.

  • Same for examples and tests... Try to add instead of change. This would be quite messy to undo by the time we're ready to merge.

  • Try to have as few changed files as possible as that would help with reasoning. Also it'll help putting this under a feature flag.

@schungx
Copy link
Collaborator

schungx commented Sep 30, 2024

I wonder how this is working out...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants