-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build pull requests and master branch using Github Actions #199
Conversation
Actually, I would suggest also include all the |
@schungx I hear you. So that would result in a lot of build combinations, so would you be OK with only adding build feature combinations on |
I would say that's fine because there really isn't any Linux-flavor specifics in the code base. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And I haven't been diligent to remove warnings on many features. That's show up in screenfuls of warnings during CI.
Do you think I need to put ignore warnings in the code base?
I've added I think this works for an initial integration if you feel like merging it. It already provides a lot of value and can be tweaked more later. |
Not sure why not because it builds fine on my Windows box and Linux VM... both release and debug. |
@udoprog I have encountered a strange thing. The CI is working well so far... I just published a new version, and it broke a lot of code. I realize that certain feature flags have errors. However, it is very strange because those feature flags are tested via CI and they all passed fine with no errors. I wonder what is happening to cause this... |
Looking at the logs, all the tests seem to have the line: So none of the tests are being run, for some reason... And strange is that Rhai shouldn't even compile without errors under some flags, yet it did in CI... |
Seems like there's a missing I don't have the time to poke it right now, feel free to give it a shot! |
Added some
basicadvanced feature matrixing.Example run from my repo: https://github.com/udoprog/rhai/actions/runs/182120816 and build status below.