Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build pull requests and master branch using Github Actions #199

Merged
merged 1 commit into from
Jul 25, 2020
Merged

Build pull requests and master branch using Github Actions #199

merged 1 commit into from
Jul 25, 2020

Conversation

udoprog
Copy link
Contributor

@udoprog udoprog commented Jul 25, 2020

Added some basic advanced feature matrixing.

Example run from my repo: https://github.com/udoprog/rhai/actions/runs/182120816 and build status below.

@schungx
Copy link
Collaborator

schungx commented Jul 25, 2020

Actually, I would suggest also include all the no_XXX features, each separately. It is a constant pain that some code changes will break some no_XXX feature and not caught.

@udoprog
Copy link
Contributor Author

udoprog commented Jul 25, 2020

@schungx I hear you.

So that would result in a lot of build combinations, so would you be OK with only adding build feature combinations on ubuntu-latest and stable?

@schungx
Copy link
Collaborator

schungx commented Jul 25, 2020

So that would result in a lot of build combinations, so would you be OK with only adding build feature combinations on ubuntu-latest and stable?

I would say that's fine because there really isn't any Linux-flavor specifics in the code base. stable only is also OK, except for no_std of course...

Copy link
Collaborator

@schungx schungx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And I haven't been diligent to remove warnings on many features. That's show up in screenfuls of warnings during CI.

Do you think I need to put ignore warnings in the code base?

@udoprog
Copy link
Contributor Author

udoprog commented Jul 25, 2020

I've added NoStdBuild, which tries to build the no_std project you are working on. I think that's a better test than trying to build the project. Note that these are marked as continue-on-error: true, since it doesn't seem to build on Linux or Windows right now.

I think this works for an initial integration if you feel like merging it. It already provides a lot of value and can be tweaked more later.

@schungx
Copy link
Collaborator

schungx commented Jul 25, 2020

since it doesn't seem to build on Linux or Windows right now.

Not sure why not because it builds fine on my Windows box and Linux VM... both release and debug.

@schungx schungx merged commit 4ee4cf1 into rhaiscript:master Jul 25, 2020
@schungx
Copy link
Collaborator

schungx commented Aug 5, 2020

@udoprog I have encountered a strange thing. The CI is working well so far...

I just published a new version, and it broke a lot of code. I realize that certain feature flags have errors.

However, it is very strange because those feature flags are tested via CI and they all passed fine with no errors.

I wonder what is happening to cause this...

@schungx
Copy link
Collaborator

schungx commented Aug 5, 2020

Looking at the logs, all the tests seem to have the line: running 0 tests

So none of the tests are being run, for some reason...

And strange is that Rhai shouldn't even compile without errors under some flags, yet it did in CI...

@udoprog
Copy link
Contributor Author

udoprog commented Aug 5, 2020

Seems like there's a missing $ in the build (should be ${{matrix.flags}}), meaning the variable is not being expanded:
https://github.com/jonathandturner/rhai/actions/runs/196429075/workflow#L53

I don't have the time to poke it right now, feel free to give it a shot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants