Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust notebooks for Python 3.11 / Elyra 4 image #50

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

caponetto
Copy link
Contributor

This PR includes the necessary changes to run the Fraud Detection tutorial on a Python 3.11 based image with Elyra v4 (from ODH Notebooks repository).

@cfchase
Copy link
Collaborator

cfchase commented Oct 9, 2024

Looks like it's related to a bug in tf2onnx and tensorflow >= 2.16
onnx/tensorflow-onnx#2348

Clean up data input
@cfchase
Copy link
Collaborator

cfchase commented Oct 10, 2024

I removed the outputs from checking in.
I added name='dense_input' which kept the input signature the same so we didn't need any further changes.
I cleaned up the pandas/numpy/transform a bit.
@caponetto and @RHRolun let me know what you think of the changes

Copy link
Contributor

@RHRolun RHRolun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caponetto
Copy link
Contributor Author

Thanks for the changes @cfchase! I've tested them and they worked as expected.

@cfchase cfchase merged commit 07b6fa4 into rh-aiservices-bu:main Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants