Skip to content

Commit

Permalink
mm-maintain-randomization-of-page-free-lists-checkpatch-fixes
Browse files Browse the repository at this point in the history
ERROR: code indent should use tabs where possible
torvalds#125: FILE: mm/shuffle.h:43:
+                return false;$

WARNING: please, no spaces at the start of a line
torvalds#125: FILE: mm/shuffle.h:43:
+                return false;$

total: 1 errors, 1 warnings, 96 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

NOTE: Whitespace errors detected.
      You may wish to use scripts/cleanpatch or scripts/cleanfile

./patches/mm-maintain-randomization-of-page-free-lists.patch has style problems, please review.

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

Please run checkpatch prior to sending patches

Cc: Dan Williams <dan.j.williams@intel.com>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: Kees Cook <keescook@chromium.org>
Cc: Keith Busch <keith.busch@intel.com>
Cc: Michal Hocko <mhocko@suse.com>
Cc: Robert Elliott <elliott@hpe.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
  • Loading branch information
akpm00 authored and hnaz committed Feb 9, 2019
1 parent ae138ac commit 62e38c8
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion mm/shuffle.h
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ static inline void shuffle_zone(struct zone *z)
static inline bool is_shuffle_order(int order)
{
if (!static_branch_unlikely(&page_alloc_shuffle_key))
return false;
return false;
return order >= SHUFFLE_ORDER;
}
#else
Expand Down

0 comments on commit 62e38c8

Please sign in to comment.