Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set the DOCTYPE by removing the DTD and creating a new one #238

Merged

Conversation

flavorjones
Copy link
Contributor

Set the DOCTYPE to "html" by removing the DTD and creating a new one.

GNOME/libxml2@8d0aaf4 prevents us from changing the node name in libxml >= 2.13.0.

See discussion in #3230 for context.

because GNOME/libxml2@8d0aaf4 prevents us from changing the node name
in libxml >= 2.13.0.

See discussion in #3230 for context.
flavorjones added a commit to sparklemotion/nokogiri that referenced this pull request Jun 12, 2024
I want to make sure that we don't break the thing we're asking
Sanitize to do; and I want to make sure we have valgrind coverage for it.

See rgrove/sanitize#238 for context.
@flavorjones
Copy link
Contributor Author

Also note that I've added a test of this workaround to Nokogiri's suite as well in sparklemotion/nokogiri#3230.

@flavorjones flavorjones force-pushed the flavorjones-handle-libxml-dtd-contraints branch from e9fc1f0 to 49f7eed Compare June 12, 2024 23:07
Copy link
Owner

@rgrove rgrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@rgrove rgrove merged commit 49f7eed into rgrove:main Jun 13, 2024
9 checks passed
@flavorjones flavorjones deleted the flavorjones-handle-libxml-dtd-contraints branch June 13, 2024 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants