Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SVG attributes to the relaxed config #161

Merged
merged 1 commit into from
Jun 4, 2017
Merged

Conversation

louim
Copy link
Contributor

@louim louim commented May 16, 2017

Hey!

SVG attributes are allowed in CSS for styling purpose, so I decided to add them to the relaxed config. Those we are mainly interested in are stroke and fill, but I decided to add all missing attributes that are supported in the spec.

Link to the spec (SVG 1.1) here: https://www.w3.org/TR/SVG/styling.html#StyleAttribute

@louim
Copy link
Contributor Author

louim commented May 16, 2017

Spec failure are related to the segfault from Nokogumbo 1.4.10.

@louim louim closed this May 19, 2017
@louim louim reopened this May 19, 2017
@rgrove rgrove merged commit e8c47d6 into rgrove:master Jun 4, 2017
@rgrove
Copy link
Owner

rgrove commented Jun 4, 2017

Thanks! Merged and released in 4.5.0.

Sorry for the delay on this. I needed to track down the root cause of those test failures first and haven't had much free time lately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants