Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds the ability to specify a Proc which is used to validate @import URLs #153

Merged
merged 2 commits into from
Jul 17, 2016

Conversation

nikz
Copy link
Contributor

@nikz nikz commented Jul 17, 2016

This is the first cut of the change described in #151.

@nikz
Copy link
Contributor Author

nikz commented Jul 17, 2016

Hmmm, the 1.9.3 build seems to be erroring. Trying to figure out what's going on there now.

@@ -381,6 +381,18 @@ Names of CSS [at-rules][at-rules] to allow that may have associated blocks
containing style rules. At-rules like `media` and `keyframes` fall into this
category. Names should be specified in lowercase.

##### :css => :at_import_url_validator
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we call this :import_url_validator instead? I don't think the "at" adds anything useful to the name.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, absolutely, I'll do that rename now. I was just trying to follow the existing naming but you're absolutely right.

@rgrove
Copy link
Owner

rgrove commented Jul 17, 2016

Looks good, thanks! I wouldn't worry about the 1.9.3 failure on Travis. I can't reproduce it locally, so it seems like a Travis glitch.

@nikz
Copy link
Contributor Author

nikz commented Jul 17, 2016

@rgrove done that rename, will see if Travis does the same thing this time around!

@nikz
Copy link
Contributor Author

nikz commented Jul 17, 2016

Sweet, glitch seems gone ¯_(ツ)_/¯

@rgrove rgrove merged commit 844f4cc into rgrove:master Jul 17, 2016
@rgrove
Copy link
Owner

rgrove commented Jul 17, 2016

Thanks! Will release this shortly as 4.1.0.

@nikz
Copy link
Contributor Author

nikz commented Jul 17, 2016

Nice, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants