Unpin Nokogumbo version #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Is there a reason that you have limited the nokogumbo version to _exactly_ 1.4.1? Is there a change (either in code or in process) that would enable updated versions to be used?
|
I started pinning the Nokogumbo version in commit 9513c97 after a broken Nokogumbo patch release caused problems for Sanitize users. Nokogumbo's been pretty stable since then though, so we can probably stop pinning if you pinky-swear not to break it again. 😉 |
|
I can't promise not to break it again; but I will promise to promptly fix or revert any commit that causes problems for sanitize. |
|
👍 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a reason that you have limited the nokogumbo version to exactly 1.4.1? Is there a change (either in code or in process) that would enable updated versions to be used?