Improve CI/CD #183
Merged
Improve CI/CD #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They don't seem to be used anyways
tmattio
force-pushed
the
ci-cd-improvements
branch
from
ccd8500 to
d473070
Compare
rgrinberg
approved these changes
Sep 8, 2020
|
@tmattio restoring cache might cause issues with a later switch creation. Right now the ocaml action uses |
Merged
|
@anuragsoni That's what I noticed after merging. I'll comment out the caching part until there is a workaround. That's a shame, the CI went from taking 20min to 2min! |
smorimoto
reviewed
Sep 9, 2020
| opam install . --deps-only --with-doc --with-test --locked --unlock-base | ||
| opam install ppx_sexp_conv base64 ppx_yojson_conv --skip-updates | ||
|
|
||
| - name: Upgrade dependencies |
There was a problem hiding this comment.
This is NOT for upgrade. This step checks the consistency of the installed opam packages.
There was a problem hiding this comment.
Thanks for the review @smorimoto! I made the changes in #184
smorimoto
reviewed
Sep 9, 2020
| if: steps.cache-opam.outputs.cache-hit != 'true' | ||
| run: opam install ocamlformat | ||
|
|
||
| - name: Upgrade dependencies |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the CI CD by: