-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade svelte #90
Upgrade svelte #90
Conversation
use svelte:element
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/rgossiaux/svelte-headlessui/6NkCMS8UYPUoJzvrHRJGfuyuwVem |
Some other notes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
You need to update the peerDependencies
to 3.47.0 as well, since users will need that for this to work. For that reason I haven't rushed to implementing this, so I'll probably merge your PR in a couple weeks (also gives us a little more time for bugs in svelte:element to be found).
Oh, and yes, the TS types can be simplified now, as you mentioned--we should delete the hardcoded list of elements. |
Thanks for this PR @benjavicente ! I know I'm responding to it a little late :) I've switched over to svelte:element in the |
This PR upgrades Svelte to use
svelte:element
in the Render component, removing the monstrosity that was needed to use theas={element}
prop.