Show status of individual tasks #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lathanh
approved these changes
Nov 2, 2023
buildstockbatch/gcp/gcp.py
Outdated
| @@ -355,10 +355,16 @@ def list_jobs(self): | |||
| logger.info(f'Showing the first 10 existing jobs that match: {request.filter}\n') | |||
| response = client.list_jobs(request) | |||
| for job in response.jobs: | |||
| task_counts = collections.defaultdict(int) | |||
| logger.debug(job) | |||
There was a problem hiding this comment.
What does this debug line output — is it redundant with the info logs (is it needed)?
There was a problem hiding this comment.
It prints out the long version of the job information with lots more details (but only when the --verbose flag is set).
There was a problem hiding this comment.
Is it redundant with the 'info' logging that follows? Would it make sense to not do the info logging if debug logging is enabled?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small update to the
--list_jobsoption: show the status of the tasks.This is helpful when checking on in-progress jobs, to see how many of the batches have finished.
Sample output: