Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retry to post-processing job start #35

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Conversation

lathanh
Copy link
Member

@lathanh lathanh commented Nov 29, 2023

Starting a Cloud Run post-processing job is two steps; first creating the job, then starting it. The attempt to start happens immediately after creating it, but sometimes creation needs a bit more time. This adds two retries to the 'start' request (for a total of three attempts), separated by one second.

@lathanh lathanh added the enhancement New feature or request label Nov 29, 2023
@lathanh lathanh self-assigned this Nov 29, 2023
Copy link

File Coverage
All files 86%
base.py 90%
eagle.py 77%
exc.py 57%
local.py 70%
postprocessing.py 84%
utils.py 91%
cloud/docker_base.py 93%
sampler/base.py 79%
sampler/downselect.py 33%
sampler/precomputed.py 93%
sampler/residential_quota.py 61%
test/test_docker.py 33%
test/test_validation.py 97%
workflow_generator/base.py 90%
workflow_generator/commercial.py 53%
workflow_generator/residential_hpxml.py 86%

Minimum allowed coverage is 33%

Generated by 🐒 cobertura-action against 4375922

@lathanh lathanh merged commit 4e555ce into gcp Nov 29, 2023
@lathanh lathanh deleted the lathanh/pp-start-retry branch November 29, 2023 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant