Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix camera vewport bug #304

Merged
merged 4 commits into from
May 10, 2024
Merged

Fix camera vewport bug #304

merged 4 commits into from
May 10, 2024

Conversation

rewin123
Copy link
Owner

@rewin123 rewin123 commented May 4, 2024

@rewin123 rewin123 added the bug Something isn't working label May 4, 2024
Copy link

codecov bot commented May 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 39 lines in your changes are missing coverage. Please review.

Project coverage is 37.76%. Comparing base (8586378) to head (03d7635).

Files Patch % Lines
crates/editor_ui/src/game_view.rs 0.00% 21 Missing ⚠️
crates/editor_ui/src/settings.rs 0.00% 15 Missing ⚠️
crates/editor_core/src/lib.rs 0.00% 1 Missing ⚠️
crates/editor_ui/src/lib.rs 0.00% 1 Missing ⚠️
crates/editor_ui/src/menu_toolbars.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #304      +/-   ##
==========================================
- Coverage   37.82%   37.76%   -0.07%     
==========================================
  Files          58       58              
  Lines        9514     9530      +16     
==========================================
  Hits         3599     3599              
- Misses       5915     5931      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@naomijub
Copy link
Collaborator

naomijub commented May 4, 2024

Lint and fmt failed, I think this can be tested, seems like a simple test implementation

@naomijub
Copy link
Collaborator

naomijub commented May 5, 2024

To have the lint fixed you should have rust latest, as the CI. Rustup update

@rewin123
Copy link
Owner Author

rewin123 commented May 5, 2024

To have the lint fixed you should have rust latest, as the CI. Rustup update

Yes, sure. I'm just hoping to wait for verification from whoever noticed the bug in the first place. As soon as I get confirmation that the bug has been fixed there too, I’ll fix clippy and upload it

@naomijub
Copy link
Collaborator

naomijub commented May 9, 2024

Works on my side (improved the macos experience as well).
Don't forget to add documentation on git lfs:

### Dependencies
 - Git LFS for assets
 
git lfs install
git lfs pull

@naomijub naomijub merged commit 6f0b571 into main May 10, 2024
8 of 10 checks passed
@naomijub naomijub deleted the fix-camera-bug branch October 10, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants