-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix camera vewport bug #304
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #304 +/- ##
==========================================
- Coverage 37.82% 37.76% -0.07%
==========================================
Files 58 58
Lines 9514 9530 +16
==========================================
Hits 3599 3599
- Misses 5915 5931 +16 ☔ View full report in Codecov by Sentry. |
Lint and fmt failed, I think this can be tested, seems like a simple test implementation |
To have the lint fixed you should have rust latest, as the CI. Rustup update |
Yes, sure. I'm just hoping to wait for verification from whoever noticed the bug in the first place. As soon as I get confirmation that the bug has been fixed there too, I’ll fix clippy and upload it |
Works on my side (improved the macos experience as well).
|
#298