separated tabs from ui crate #269
Conversation
rewin123
added this to the 0.6 (UI improvements, code clearing and QOL changes) milestone
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v0.6 #269 +/- ##
=======================================
Coverage 34.78% 34.78%
=======================================
Files 58 62 +4
Lines 9301 9301
=======================================
Hits 3235 3235
Misses 6066 6066 ☔ View full report in Codecov by Sentry. |
|
Should this target |
Oh, yes. Misselect |
| "modules/bevy_xpbd_plugin" | ||
| ] | ||
| , "crates/editor_tabs"] |
There was a problem hiding this comment.
this is already included in "crates/*"
|
|
||
| [workspace.package] | ||
| version = "0.5.0" | ||
| version = "0.6.0" |
| @@ -22,6 +22,7 @@ space_prefab.workspace = true | |||
| space_undo.workspace = true | |||
| space_persistence.workspace = true | |||
| space_shared.workspace = true | |||
| space_editor_tabs.workspace = true | |||
There was a problem hiding this comment.
Have you checked which crates can be removed from editor_ui cargo.toml?
| @@ -0,0 +1,15 @@ | |||
| /// Colors used in editor | |||
| use bevy_egui::egui::{Color32, Stroke}; | |||
There was a problem hiding this comment.
I think color, sizing and typography would live better in the UI crate, as they are ui elements. If this crate is the one responsible for the application ui, maybe call this editor_ui and the other editor_ui_extensions/editor_ui_components?
There was a problem hiding this comment.
Yes, this is undoubtedly better located in editor_ui crate. However, these colours are referenced by editor_tabs. However, the PR is already quite large, so I decided to stop with just shuffling the code for now. And the improvement of the separations will be in multiple PRs
|
|
||
| #[derive(Resource, Clone, PartialEq, Reflect, InspectorOptions)] | ||
| #[reflect(Resource, Default, InspectorOptions)] | ||
| pub struct Sizing { |
| use space_undo::ChangeChain; | ||
|
|
||
| pub struct ChangeChainViewPlugin; | ||
|
|
||
| impl Plugin for ChangeChainViewPlugin { | ||
| fn build(&self, app: &mut App) { | ||
| app.editor_tab_by_trait( | ||
| super::editor_tab::EditorTabName::Other("Change Chain".to_string()), | ||
| EditorTabName::Other("Change Chain".to_string()), |
There was a problem hiding this comment.
UX suggested that Change Chain is a non intuitive name for Undo/Redo logic, Maybe we could call it Undo Chain, Undo/Redo Config or Undo Max Chain?
There was a problem hiding this comment.
We can! But in another PR, this PR only about code moving
Currently its just code moving. Want to split separations PRs in multiple steps