bug: Camera app is not being detected properly

[amycatgirl]

What happened?

I was trying to send a photo through Revolt and pressed the camera button to take a picture, but it kept telling me I had no camera app installed despite one being present.

Reproduction steps

1. Go to a channel
2. Open the attachments menu by pressing the + button on the message box
3. Press the camera button

App information

App ID: chat.revolt
App Version: 1.3.6b
App Type: GPAA
API Host: api.revolt.chat
API Version: 0.8.8
Runtime SDK: 36
Model: Google Lynx (Pixel 7a)

[alexjyong]

@amycatgirl Looks like it was disabled in the manifest here: https://github.com/revoltchat/android/blob/dev/app/src/main/AndroidManifest.xml#L19

Judging by the comments, looks like it was disabled since LiveKit currently isn't included in the application at the time of writing. Not too sure if it needs to be disabled for any other reason though, and it looks like this resulted in the camera option in text attachments getting caught in the crossfire.

I renabled the perms on a local build, gave the app permission and now it works:

Assuming it's not disabled for any other reason, quickest fix would be just to uncomment that line in the manifest, but it would also be helpful to have the app prompt the user for camera permission, as it does not have it by default and must be manually added by the user.

[alexjyong]

Actually, after talking to @infi, found out my original assessment was a little off. The io.github.g00fy2.quickie.ScanQRCode library allows Camera permissions, so modifying the manifest isn't necessary, but, the user still has to add camera permissions manually to the app, OR try to scan a friend QR code with the app (which by then the app will prompt the user for permissions if it's not enabled.)

It would be useful if the camera in the picker did this as well IMHO.