Skip to content

Commit

Permalink
Merge pull request #4 from rickstaa/fix_reviewdog_exit_code_bug
Browse files Browse the repository at this point in the history
Fix reviewdog exit code bug and error format syntax problem
  • Loading branch information
prologic authored Nov 23, 2020
2 parents 3a7ecc2 + 7b777e5 commit 0e804be
Show file tree
Hide file tree
Showing 5 changed files with 1,401 additions and 3 deletions.
1 change: 1 addition & 0 deletions .github/workflows/reviewdog.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ jobs:
name: runner / remark-lint
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@master
- name: remark-lint-github-check
uses: ./
with:
Expand Down
7 changes: 7 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
# Folders to ignore
.vscode/
node_modules/

# Files to ignore
.package-lock.json
.package.json
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
FROM prologic/remark-lint:latest

RUN wget -O - -q https://raw.githubusercontent.com/reviewdog/reviewdog/master/install.sh| sh -s -- -b /usr/local/bin/ v0.9.15
RUN wget -O - -q https://raw.githubusercontent.com/reviewdog/reviewdog/master/install.sh | sh -s -- -b /usr/local/bin/ v0.11.0
RUN apk --no-cache -U add git

COPY entrypoint.sh /entrypoint.sh
Expand Down
4 changes: 2 additions & 2 deletions entrypoint.sh
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,6 @@ if [ "${INPUT_REPORTER}" = 'github-pr-review' ]; then
exit 1
else
# github-pr-check,github-check (GitHub Check API) doesn't support markdown annotation.
remark --quiet --use=remark-preset-lint-recommended . 2>&1 |
reviewdog -efm="%f\n%l:%c: %m" -name="remark-lint" -reporter="${INPUT_REPORTER:-github-pr-check}" -level="${INPUT_LEVEL}" -tee
remark --frail --quiet --use=remark-preset-lint-recommended . 2>&1 |
reviewdog -f=remark-lint -name="remark-lint" -reporter="${INPUT_REPORTER:-github-pr-check}" -level="${INPUT_LEVEL}" -tee
fi
Loading

0 comments on commit 0e804be

Please sign in to comment.