Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prod dockerfile to include package file and don't copy unneccesary generated file #597

Merged
merged 5 commits into from
Jul 24, 2024
Merged

fix: prod dockerfile to include package file and don't copy unneccesary generated file #597

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a6e1733
chore: backend prod Dockerfile
Nabhag8848 Jul 22, 2024
4d2c537
fix: remove unused config
Nabhag8848 Jul 22, 2024
d42bf4d
fix: prod dockerfile to include package file
Nabhag8848 Jul 24, 2024
14ed8c6
Merge branch 'main' into feat/backend-container
Nabhag8848 Jul 24, 2024
5e2c818
fix: dockerfile comment
Nabhag8848 Jul 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .dockerignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,7 @@ public
README.md
packages/react
packages/js
packages/vue
packages/vue
packages/backend/dist
packages/backend/generated
.env
10 changes: 5 additions & 5 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,19 +130,19 @@ RUN echo "SERVER_PORT=$SERVER_PORT" > .env \

RUN rm -rf node_modules && yarn cache clean && yarn install
RUN npm install -g fern-api@0.16.22 && fern -v && fern generate --log-level debug
RUN mkdir -p /app/packages/backend/dist/generated && cp -r /app/packages/backend/generated/typescript /app/packages/backend/dist/generated
RUN yarn workspace @revertdotdev/backend build
RUN yarn workspace @revertdotdev/backend build:prod

# remove development dependencies
RUN npm prune --production

FROM node:18-alpine AS runtime_image
WORKDIR /app/

#copy from build image
# copy from build image
COPY --from=build_image /app/packages/backend/dist ./dist
COPY --from=build_image /app/node_modules ./node_modules
COPY --from=build_image /app/.env ./dist/.env
COPY --from=build_image /app/.env ./.env
COPY --from=build_image /app/packages/backend/package.json ./package.json

WORKDIR /app/dist
CMD ["node", "index.js"]
CMD ["yarn", "start"]
5 changes: 4 additions & 1 deletion packages/backend/.dockerignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,7 @@ README.md
packages/client
packages/react
packages/js
packages/vue
packages/vue
generated
dist
.env
1 change: 0 additions & 1 deletion packages/backend/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ dotenv.config();

const config = {
PORT: process.env.SERVER_PORT || 4001,
DATABASE: process.env.MONGO_DATABASE,
REDIS_URL: process.env.REDIS_SERVER_URL!,
HUBSPOT_CLIENT_ID: process.env.HUBSPOT_CLIENT_ID,
HUBSPOT_CLIENT_SECRET: process.env.HUBSPOT_CLIENT_SECRET,
Expand Down
1 change: 1 addition & 0 deletions packages/backend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
"private": true,
"scripts": {
"build": "mkdir -p ./dist/generated && cp -r ./generated/ ./dist/generated && tsc",
"build:prod": "tsc",
"watch": "tsc -w",
"start": "NODE_ENV=production node ./dist/index.js",
"start:prod": "yarn db-deploy && NODE_ENV=production node ./dist/index.js",
Expand Down
Loading