feat: Github issues support #557

manish-singh-bisht · 2024-05-06T10:02:53Z

Description

Fixes #252

added github issue integration
task,user,collections,comments endpoints added
oauth added

https://www.loom.com/share/8404afa6be614e098a02268a3b5b88a1 (users,tasks,collections,comment(create,update,getComment))

https://www.loom.com/share/2d0ee45aae304e11baea2378253d62f3 (comment-get comments- 8 May 2024)

Type of change

New feature (non-breaking change which adds functionality)
This change requires a documentation update

How Has This Been Tested?

postman

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have been merged and published in downstream modules

vercel · 2024-05-06T10:02:57Z

@manish-singh-bisht is attempting to deploy a commit to the OpenInt Team on Vercel.

A member of the Team first needs to authorize it.

github-actions · 2024-05-06T10:03:06Z

Thank you for following the naming conventions for pull request titles! 🙏

…tion for github,and other needed for the previous.

vercel · 2024-05-08T18:40:49Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
revert-client	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 31, 2024 10:02am

manish-singh-bisht · 2024-05-08T18:51:24Z

things to change

image links-

github.mdx,

packages/client/src/features/integration/enums/metadata.ts,

packages/backend/services/metadata.ts

Nabhag8848

@manish-singh-bisht added some comments can you have a look, ping me here once you have done.

also have you tested this integration for customRedirectUrls ? if not please do and lemme know if that works or not this one: https://github.com/revertinc/revert/pull/574/files

Nabhag8848 · 2024-07-29T11:53:50Z

packages/backend/services/metadata.ts

+                    integrationId: TP_ID.github,
+                    name: 'GitHub',
+                    imageSrc:
+                        'https://res.cloudinary.com/dfcnic8wq/image/upload/v1702983006/Revert/szfzkoagws7h3miptezo.png',


Looks like this is image of Jira

yes this jatin will provide.

@manish-singh-bisht https://res.cloudinary.com/dwoiwg0t5/image/upload/f_auto,q_auto/d4jdtttg8ptk2ab9kpz7

packages/backend/services/ticket/collection.ts

packages/backend/services/ticket/comment.ts

packages/backend/services/ticket/task.ts

Nabhag8848 · 2024-07-29T12:07:06Z

packages/client/src/features/integration/enums/metadata.ts

+
+    github: {
+        name: 'GitHub',
+        logo: 'https://res.cloudinary.com/dfcnic8wq/image/upload/v1711549311/Revert/cmqpors8m8tid9zpn9ak.png',


Suggested change

logo: 'https://res.cloudinary.com/dfcnic8wq/image/upload/v1711549311/Revert/cmqpors8m8tid9zpn9ak.png',

logo: GITHUBLOGO,

manish-singh-bisht · 2024-07-29T13:52:25Z

@manish-singh-bisht added some comments can you have a look, ping me here once you have done.

also have you tested this integration for customRedirectUrls ? if not please do and lemme know if that works or not this one: https://github.com/revertinc/revert/pull/574/files

works

packages/backend/services/ticket/user.ts

Nabhag8848 · 2024-07-30T06:08:55Z

packages/backend/services/metadata.ts

+                    integrationId: TP_ID.github,
+                    name: 'GitHub',
+                    imageSrc:
+                        'https://res.cloudinary.com/dfcnic8wq/image/upload/v1702983006/Revert/szfzkoagws7h3miptezo.png',


@manish-singh-bisht https://res.cloudinary.com/dwoiwg0t5/image/upload/f_auto,q_auto/d4jdtttg8ptk2ab9kpz7

manish-singh-bisht · 2024-07-30T12:35:39Z

things to change
1. image links-
github.mdx,

packages/client/src/features/integration/enums/metadata.ts,

packages/backend/services/metadata.ts

@Nabhag8848 we need images for the above mentioned places.thank you

Nabhag8848 · 2024-07-30T13:57:42Z

@manish-singh-bisht
metadata: https://res.cloudinary.com/dwoiwg0t5/image/upload/f_auto,q_auto/d4jdtttg8ptk2ab9kpz7
docs: https://res.cloudinary.com/dwoiwg0t5/image/upload/f_auto,q_auto/lmmkmmgaoatdbzhgbymy
enums: https://res.cloudinary.com/dwoiwg0t5/image/upload/t_github-grayscal/d4jdtttg8ptk2ab9kpz7.jpg

Nabhag8848

@manish-singh-bisht LGTM

init

be7e8f1

manish-singh-bisht marked this pull request as draft May 6, 2024 10:03

manish-singh-bisht and others added 2 commits May 7, 2024 15:30

Merge branch 'revertinc:main' into gh

e5212a3

feat: added oauth,task,comments,users,collections endpoints,documenta…

712323d

…tion for github,and other needed for the previous.

manish-singh-bisht marked this pull request as ready for review May 7, 2024 21:20

vercel bot deployed to Preview May 8, 2024 18:43 View deployment

manish-singh-bisht and others added 6 commits June 3, 2024 12:31

merge

a18b916

Update .env.example

b419638

changes as per the pr-redirect url

9980bf5

made changes as per the webhook creation pr

f0fc0fe

docs update link

c0d4f02

Merge branch 'revertinc:main' into gh

d4553cc

Nabhag8848 requested changes Jul 29, 2024

View reviewed changes

manish-singh-bisht and others added 2 commits July 29, 2024 18:26

Merge branch 'revertinc:main' into gh

2c1e7cf

corrected the OR condition

d9ec56f

manish-singh-bisht requested review from Nabhag8848 July 29, 2024 13:52

Nabhag8848 requested changes Jul 30, 2024

View reviewed changes

manish-singh-bisht added 2 commits July 30, 2024 19:45

image links

14d9edd

revert dashboard github image link

a0c0855

Nabhag8848 approved these changes Jul 31, 2024

View reviewed changes

vercel bot deployed to Preview July 31, 2024 10:02 View deployment

Nabhag8848 merged commit 8bcad8e into revertinc:main Jul 31, 2024
3 of 4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Github issues support #557

feat: Github issues support #557

manish-singh-bisht commented May 6, 2024 •

edited

Loading

vercel bot commented May 6, 2024

github-actions bot commented May 6, 2024 •

edited

Loading

vercel bot commented May 8, 2024 •

edited

Loading

manish-singh-bisht commented May 8, 2024

Nabhag8848 left a comment

Nabhag8848 Jul 29, 2024

manish-singh-bisht Jul 29, 2024

Nabhag8848 Jul 30, 2024

Nabhag8848 Jul 29, 2024

manish-singh-bisht commented Jul 29, 2024

Nabhag8848 Jul 30, 2024

manish-singh-bisht commented Jul 30, 2024

Nabhag8848 commented Jul 30, 2024

Nabhag8848 left a comment

	logo: 'https://res.cloudinary.com/dfcnic8wq/image/upload/v1711549311/Revert/cmqpors8m8tid9zpn9ak.png',
	logo: GITHUBLOGO,

feat: Github issues support #557

feat: Github issues support #557

Conversation

manish-singh-bisht commented May 6, 2024 • edited Loading

Description

Type of change

How Has This Been Tested?

Checklist:

vercel bot commented May 6, 2024

github-actions bot commented May 6, 2024 • edited Loading

vercel bot commented May 8, 2024 • edited Loading

manish-singh-bisht commented May 8, 2024

Nabhag8848 left a comment

Choose a reason for hiding this comment

Nabhag8848 Jul 29, 2024

Choose a reason for hiding this comment

manish-singh-bisht Jul 29, 2024

Choose a reason for hiding this comment

Nabhag8848 Jul 30, 2024

Choose a reason for hiding this comment

Nabhag8848 Jul 29, 2024

Choose a reason for hiding this comment

manish-singh-bisht commented Jul 29, 2024

Nabhag8848 Jul 30, 2024

Choose a reason for hiding this comment

manish-singh-bisht commented Jul 30, 2024

Nabhag8848 commented Jul 30, 2024

Nabhag8848 left a comment

Choose a reason for hiding this comment

manish-singh-bisht commented May 6, 2024 •

edited

Loading

github-actions bot commented May 6, 2024 •

edited

Loading

vercel bot commented May 8, 2024 •

edited

Loading