refactor: rename and update category constants and logic in ical parser

revelaction · Oct 2, 2024 · 5a90df6 · 5a90df6
1 parent 86271a7
commit 5a90df6
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/ical/parse.go b/ical/parse.go
@@ -16,8 +16,8 @@ import (
 	"time"
 )
 
-const NoDateCategory = "show-no-date"
-const NoAlarmCategory = "show-no-alarm"
+const ShowNoDateCategory = "show-no-date"
+const ShowAlarmCategory = "show-alarm"
 
 type Parser struct {
 	notifications []notify.Notification
@@ -200,19 +200,18 @@ func (p *Parser) buildNotification(event *ics.VEvent) notify.Notification {
 	var categories []string
 
 	n.ShowDate = true
-	n.ShowAlarm = true
 
 	for _, p := range event.Properties {
 		if p.IANAToken == string(ics.ComponentPropertyComment) {
 			comments = append(comments, p.Value)
 		}
 		if p.IANAToken == string(ics.ComponentPropertyCategories) {
-			if p.Value == NoDateCategory {
+			if p.Value == ShowNoDateCategory {
 				n.ShowDate = false
 				continue
 			}
-			if p.Value == NoAlarmCategory {
-				n.ShowAlarm = false
+			if p.Value == ShowAlarmCategory {
+				n.ShowAlarm = true
 				continue
 			}
 			categories = append(categories, p.Value)

diff --git a/ical/parse_test.go b/ical/parse_test.go
@@ -565,7 +565,8 @@ SUMMARY:Event with Categories
 DESCRIPTION:Event with categories A, B, show-no-alarm
 CATEGORIES:A
 CATEGORIES:B
-CATEGORIES:show-no-alarm
+CATEGORIES:show-alarm
+CATEGORIES:show-no-date
 END:VEVENT
 END:VCALENDAR
 `)