fix log json missing unigram bigram info if output sbs not set

revdotcom · Apr 18, 2024 · 2c76656 · 2c76656
1 parent 374b2c5
commit 2c76656
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/src/fstalign.cpp b/src/fstalign.cpp
@@ -695,6 +695,7 @@ void HandleWer(FstLoader& refLoader, FstLoader& hypLoader, SynonymEngine &engine
     }
   }
 
+  JsonLogUnigramBigramStats(topAlignment);
   if (!output_sbs.empty()) {
     logger->info("output_sbs = {}", output_sbs);
     WriteSbs(topAlignment, stitches, output_sbs);

diff --git a/src/wer.cpp b/src/wer.cpp
@@ -603,6 +603,10 @@ void WriteSbs(wer_alignment &topAlignment, const vector<Stitching>& stitches, st
     myfile << fmt::format("{0:>20}\t{1}", group.first, group.second) << endl;
   }
 
+  myfile.close();
+}
+
+void JsonLogUnigramBigramStats(wer_alignment &topAlignment) {
   for (const auto &a : topAlignment.unigram_stats) {
     string word = a.first;
     gram_error_counter u = a.second;
@@ -626,6 +630,4 @@ void WriteSbs(wer_alignment &topAlignment, const vector<Stitching>& stitches, st
     jsonLogger::JsonLogger::getLogger().root["wer"]["bigrams"][word]["precision"] = u.precision;
     jsonLogger::JsonLogger::getLogger().root["wer"]["bigrams"][word]["recall"] = u.recall;
   }
-
-  myfile.close();
 }
diff --git a/src/wer.h b/src/wer.h
@@ -50,3 +50,4 @@ typedef vector<pair<size_t, string>> ErrorGroups;
 
 void AddErrorGroup(ErrorGroups &groups, size_t &line, string &ref, string &hyp);
 void WriteSbs(wer_alignment &topAlignment, const vector<Stitching>& stitches, string sbs_filename);
+void JsonLogUnigramBigramStats(wer_alignment &topAlignment);