Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPOstart login failed #1842

Closed
6 tasks
lagosazules opened this issue Oct 2, 2024 · 29 comments
Closed
6 tasks

NPOstart login failed #1842

lagosazules opened this issue Oct 2, 2024 · 29 comments
Labels
bug Something isn't working

Comments

@lagosazules
Copy link

lagosazules commented Oct 2, 2024

Selecting NPOstart live TV, any channel gives a error message Retrospect Login Failed: 'Could not log on the selected channel'

Selecting 'OK' will opening the channel anyway

Expected Behavior

Actual Behavior

Possible Fix

To Reproduce

Steps to reproduce the behavior:

  1. Open Retrospect
  2. Select National, NPOstart, Live TV, Any channel
  3. Select 'OK' to open the channel anyway

Debuglog

The debug retrospect.log can be found here:

IMG_20241002_134305_240

Your Environment

Used Operating system:

  • X Firestick
  • iOS
  • Linux
  • OSX
  • Raspberry-Pi
  • Windows
  • Windows UWP

Used versions:

  • Kodi version: 21.0 20240406
  • Retrospect version: 5.7.18
@lagosazules lagosazules added the bug Something isn't working label Oct 2, 2024
@basrieter
Copy link
Collaborator

I need a debug retrospect.log.

@lagosazules
Copy link
Author

kodi.log.zip
](url)

@lagosazules
Copy link
Author

Sorry here the debug log
1kodi-debug.log.zip

@basrieter
Copy link
Collaborator

This is a kodi.log. Please provide a debug retrospect.log by changing the logging inside Retrospect to debug, then reproduce the issue, and use the built-in functionality to upload the logfile. Post the link (check the link works) here. Not the logfile.

@lagosazules
Copy link
Author

lagosazules commented Oct 2, 2024

@basrieter
Copy link
Collaborator

Did you configure a NPO account within Retrospect?

@lagosazules
Copy link
Author

No, I never needed that, it worked fine for years without,
I did it now and the problem is gone
Thanks and sorry for the trouble

@basrieter
Copy link
Collaborator

NP. I am still in doubt how to handle this. For users abroad it is required, for users in NL not always. I will leave this issue open as a reminder to think on a solution. But good to hear it is working now.

@lagosazules
Copy link
Author

I'm outside of NL but to see the Live channels sinds a couple of months I use a dedicated VPN to a private server and IP in the house of family in NL, before I used a normal VPN service but I had never this problem till I noticed it some weeks ago

@duck7000
Copy link

well i created a npo account, configured it in retrospect and still get the error could not log in?

It used to work to just ignore this error but since yesterday (21-10-2024) none of the npo channnels will play

@basrieter
Copy link
Collaborator

basrieter commented Oct 22, 2024

I need a debug log for that. Double check you are not mixing up the Retrospect pin and NPO password.

So enable debug logging in Retrospect, reproduce the issue and provide a Retrospect.log here as attachment.

ALSO: I released a fix for NPO yesterday. Make sure you have 5.7.20 installed

@FRvanderVeen
Copy link

FRvanderVeen commented Nov 11, 2024

I also do have the issue that NPO says that log-in is required, but nonetheless it is working. I'm located in NL.
Here is my log: https://paste.kodi.tv/aqubigameq

@basrieter
Copy link
Collaborator

I know, so please create a login in, and configure it in Retrospect to resolve the issue.

@spacie2136
Copy link

Same issue here.

Maybe a good solution to change the XbmcWrapper.show_dialog function for a Toast style. That way it will not require any user input but the user will still recieve a warning.

    if data_parser.LogOnRequired:
        Logger.info("One or more dataparsers require logging in.")
        self.loggedOn = self.log_on()
        if not self.loggedOn:
            Logger.warning("Could not log on for: %s", self)
            title = LanguageHelper.get_localized_string(LanguageHelper.LoginErrorTitle)
            text = LanguageHelper.get_localized_string(LanguageHelper.LoginErrorText)
            XbmcWrapper.show_dialog(title, text)

@joopdo
Copy link

joopdo commented Dec 19, 2024

@spacie2136 Thanks for that, changing as follows removed the message for me.

        if data_parser.LogOnRequired:
            Logger.info("One or more dataparsers require logging in.")
            self.loggedOn = self.log_on()
            if not self.loggedOn:
                Logger.warning("Could not log on for: %s", self)
                #title = LanguageHelper.get_localized_string(LanguageHelper.LoginErrorTitle)
                #text = LanguageHelper.get_localized_string(LanguageHelper.LoginErrorText)
                #XbmcWrapper.show_dialog(title, text)

        Logger.debug("Processing Updater from %s", data_parser)
        return data_parser.Updater(item)

@basrieter
Copy link
Collaborator

I could change that.

@basrieter
Copy link
Collaborator

@spacie2136 Thanks for that, changing as follows removed the message for me.

        if data_parser.LogOnRequired:
            Logger.info("One or more dataparsers require logging in.")
            self.loggedOn = self.log_on()
            if not self.loggedOn:
                Logger.warning("Could not log on for: %s", self)
                #title = LanguageHelper.get_localized_string(LanguageHelper.LoginErrorTitle)
                #text = LanguageHelper.get_localized_string(LanguageHelper.LoginErrorText)
                #XbmcWrapper.show_dialog(title, text)

        Logger.debug("Processing Updater from %s", data_parser)
        return data_parser.Updater(item)

Please don't do this, as it will impact all channels and will cause issues. I will change the pop-up into a notification.

BUT: Just create an NPO login and configure it. NPO requires accounts for some streams and always require accounts when watching from abroad.

@basrieter
Copy link
Collaborator

Please try this: https://github.com/retrospect-addon/plugin.video.retrospect/archive/refs/heads/1842-npostart-login-failed.zip

Or just create an NPO account.

@Johpin1
Copy link

Johpin1 commented Dec 20, 2024

Thanks for the fix: the notification is better than a dialog box. However,
commenting out title, text and XbmcWrapper.show_dialog did not introduce any
issues to me.

According to https://npo.nl/start/aanmelden it seems not required to
register for watching tv livestreams or watching episodes later on.
I don't need the additional features like profiles or personal
recommendations based on my history of watching.

PS In het bestand channels/channel.nos/nos2010/chn_nos2010.json is
https://www.npostart.nl/npo-id-gebruiksvoorwaarden te vinden, maar deze
internetpagina blijkt niet meer te bestaan.

@basrieter
Copy link
Collaborator

Thanks for the fix: the notification is better than a dialog box. However, commenting out title, text and XbmcWrapper.show_dialog did not introduce any issues to me.

According to https://npo.nl/start/aanmelden it seems not required to register for watching tv livestreams or watching episodes later on. I don't need the additional features like profiles or personal recommendations based on my history of watching.

PS In het bestand channels/channel.nos/nos2010/chn_nos2010.json is https://www.npostart.nl/npo-id-gebruiksvoorwaarden te vinden, maar deze internetpagina blijkt niet meer te bestaan.

I will double check. But I do remember there was a thing.

@basrieter
Copy link
Collaborator

basrieter commented Dec 20, 2024

Please check: https://github.com/retrospect-addon/plugin.video.retrospect/archive/refs/heads/1842-npostart-login-failed.zip

I now only use a login if you configured one.

EDIT: In deze zip zit nog niet #1874

@Johpin1
Copy link

Johpin1 commented Dec 20, 2024

It works like a charm!

@basrieter
Copy link
Collaborator

Will push an official release soon.

@duck7000
Copy link

I now only use a login if you configured one.

This is the best approach i guess.
If you add account credentials this issue is traded in for a pin request (for every channel) which i don't use or want to use.

Thanks!

@basrieter
Copy link
Collaborator

I now only use a login if you configured one.

This is the best approach i guess. If you add account credentials this issue is traded in for a pin request (for every channel) which i don't use or want to use.

Thanks!

Great! The PIN you only need once every couple of months. It is just to keep your log-in secure.

@duck7000
Copy link

I meant the retrospect pin vault

@basrieter
Copy link
Collaborator

I meant the retrospect pin vault

I know: but you only need it to get a session token for NPO, and then not for a long time.

@duck7000
Copy link

mm that is not my experience, pin is asked after every boot of libreelec for every channel and channel change
That is why i didn't like your solution to create a account in the first place to get rid of the not logged in warning.

So your solution to only use a configured login is for me the best approach, no account, no pin vault and no warning, great!

@basrieter
Copy link
Collaborator

mm that is not my experience, pin is asked after every boot of libreelec for every channel and channel change That is why i didn't like your solution to create a account in the first place to get rid of the not logged in warning.

So your solution to only use a configured login is for me the best approach, no account, no pin vault and no warning, great!

That should not be, unless you manually delete stuff in the profile folder. But hey, if you are happy now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

7 participants