Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CORAL_PLANTS blocktag #1047

Open
wants to merge 1 commit into
base: 2.0
Choose a base branch
from
Open

Conversation

Axionize
Copy link

@Axionize Axionize commented Nov 3, 2024

Also add new ALIVE_CORAL_PLANTS and DEAD_CORAL_PLANTS blocktags

@booky10
Copy link
Collaborator

booky10 commented Nov 3, 2024

These tags don't exist in vanilla, not even in snapshots, why should we add them?

@Axionize
Copy link
Author

Axionize commented Nov 3, 2024

I added the dead states because of falses in Grim due to dead coral not being modeled as coral with the same hitboxes.

I figured someone somewhere would still want the old behavior of only getting alive coral and dead coral. The important thing is to add the dead coral to the corals blocktag.

I wasn't aware blocktags were just ports off a vanilla feature. I'll delete the new tags and just leave this PR to add the dead corals to the coral tags if you're insistent on it.

@booky10
Copy link
Collaborator

booky10 commented Nov 4, 2024

you can still add them, just move them to the bottom of the class - packetevents already has some "inofficial"/"legacy" block tags

everything above the comments is auto-generated and will be replaced with the next version update

i'm also planning on re-designing the item/block tags, as they no longer represent vanilla's tags properly

@Axionize
Copy link
Author

Axionize commented Nov 5, 2024

I'm not sure exactly where you mean by bottom of the class. At the end of the entries or at the actual bottom below the code? what about adding entries to the blocktag?

@booky10
Copy link
Collaborator

booky10 commented Nov 5, 2024

See how GLASS_BLOCKS or GLASS_PANES are defined

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants