Merge pull request #713 from retejs/new-linter

fix: update cli and fix linting errors

.gitignore

@@ -4,7 +4,9 @@ node_modules
 .sonarlint
 .scannerwork
 .nyc_output
-coverage
+/coverage
 npm-debug.log
 /dist
 docs
+.rete-cli
+.sonar

eslint.config.mjs

@@ -0,0 +1,6 @@
+import tseslint from 'typescript-eslint';
+import configs from 'rete-cli/configs/eslint.mjs';
+
+export default tseslint.config(
+  ...configs
+)

package.json

@@ -28,8 +28,7 @@
   },
   "devDependencies": {
     "jest-environment-jsdom": "^29.1.2",
-    "rete-cli": "^1.0.3",
-    "typescript": "4.8.4"
+    "rete-cli": "~2.0.1"
   },
   "dependencies": {
     "@babel/runtime": "^7.21.0"

src/presets/classic.ts

@@ -128,9 +128,9 @@ export class Control {
  */
 type InputControlOptions<N> = {
   /** Whether the control is readonly. Default is `false` */
-  readonly?: boolean,
+  readonly?: boolean
   /** Initial value of the control */
-  initial?: N,
+  initial?: N
   /** Callback function that is called when the control value changes */
   change?: (value: N) => void
 }
@@ -150,7 +150,7 @@ export class InputControl<T extends 'text' | 'number', N = T extends 'text' ? st
   constructor(public type: T, public options?: InputControlOptions<N>) {
     super()
     this.id = getUID()
-    this.readonly = options?.readonly
+    this.readonly = options?.readonly ?? false
 
     if (typeof options?.initial !== 'undefined') this.value = options.initial
   }
@@ -161,7 +161,7 @@ export class InputControl<T extends 'text' | 'number', N = T extends 'text' ? st
    */
   setValue(value?: N) {
     this.value = value
-    if (this.options?.change) this.options.change(value)
+    if (this.options?.change) this.options.change(value!)
   }
 }
 

src/scope.ts

@@ -1,3 +1,4 @@
+/* eslint-disable @typescript-eslint/no-explicit-any */
 /* eslint-disable @typescript-eslint/naming-convention */
 import {
   AcceptPartialUnion, CanAssignSignal, GetAssignmentReferences, GetNonAssignableElements, Tail
@@ -19,8 +20,8 @@ export type Pipe<T> = (data: T) => Promise<undefined | T> | undefined | T
 export type CanAssignEach<D extends any[], F extends any[]> = D extends [infer H1, ...infer Tail1]
   ? (
     F extends [infer H2, ...infer Tail2] ?
-    [CanAssignSignal<H1, H2>, ...CanAssignEach<Tail1, Tail2>]
-    : []
+      [CanAssignSignal<H1, H2>, ...CanAssignEach<Tail1, Tail2>]
+      : []
   ) : []
 
 export type ScopeAsParameter<S extends Scope<any, any[]>, Current extends any[]> = (CanAssignEach<[S['__scope']['produces'], ...S['__scope']['parents']], Current>[number] extends true
@@ -45,8 +46,8 @@ export type NestedScope<S extends Scope<any, any[]>, Current extends any[]> = (C
 export function useHelper<S extends Scope<any, any[]>, Signals>() {
   type T1 = S['__scope']['parents'][number]
   return {
-    debug<T extends GetNonAssignableElements<T1, Signals>>(f: (p: GetAssignmentReferences<T, Signals>) => T) {
-      f
+    debug<T extends GetNonAssignableElements<T1, Signals>>(_f: (p: GetAssignmentReferences<T, Signals>) => T) {
+      /* placeholder */
     }
   }
 }
@@ -75,17 +76,15 @@ export class Signal<T> {
   }
 }
 
-type Type<T> = {
-  new(...args: any[]): T;
-} | (abstract new (...args: any[]) => T)
+type Type<T> = (new(...args: any[]) => T) | (abstract new (...args: any[]) => T)
 
 /**
  * Base class for all plugins and the core. Provides a signals mechanism to modify the data
  */
 export class Scope<Produces, Parents extends unknown[] = []> {
   signal = new Signal<AcceptPartialUnion<Produces | Parents[number]>>()
   parent?: any // Parents['length'] extends 0 ? undefined : Scope<Parents[0], Tail<Parents>>
-  __scope: {
+  __scope!: {
     produces: Produces
     parents: Parents
   }

src/utility-types.ts

@@ -1,5 +1,6 @@
 /* eslint-disable @typescript-eslint/no-explicit-any */
 
+// eslint-disable-next-line @typescript-eslint/no-redundant-type-constituents
 export type AcceptPartialUnion<T> = T | any
 
 export type Tail<T extends any[]> = ((...args: T) => void) extends (head: any, ...tail: infer U) => any ? U : never
@@ -11,7 +12,7 @@ export type UnionToIntersection<U> = (
   : never
 
 type StrictExcludeInner<T, U> = 0 extends (
-    U extends T ? [T] extends [U] ? 0 : never : never
+  U extends T ? [T] extends [U] ? 0 : never : never
 ) ? never : T
 export type StrictExclude<T, U> = T extends unknown ? StrictExcludeInner<T, U> : never
 
@@ -25,17 +26,17 @@ export type FilterMatch<T extends any[], V> = T extends [infer Head, ...infer _T
   ? ([Head] extends [V]
     ? [Head, ...FilterMatch<_Tail, V>]
     : FilterMatch<_Tail, V>
-  ): []
+  ) : []
 
 export type CanAssignToAnyOf<Provides, Requires> = FilterMatch<UnionToTuple<Provides>, Requires> extends [] ? false : true
 
 export type CanAssignEachTupleElemmentToAnyOf<Provides, Requires extends any[]> = Requires extends [infer Head, ...infer _Tail]
-    ? CanAssignToAnyOf<Provides, Head> extends true ?
-      (_Tail extends []
-        ? true
-        : CanAssignEachTupleElemmentToAnyOf<Provides, _Tail>
-      ): false
-    : false
+  ? CanAssignToAnyOf<Provides, Head> extends true ?
+    (_Tail extends []
+      ? true
+      : CanAssignEachTupleElemmentToAnyOf<Provides, _Tail>
+    ) : false
+  : false
 
 export type CanAssignEachToAnyOf<Provides, Requires> = CanAssignEachTupleElemmentToAnyOf<Provides, UnionToTuple<Requires>>
 

src/utils.ts

@@ -1,8 +1,4 @@
-/* global globalThis*/
-
-const nodeCrypto = () => import('node:crypto')
-
-const crypto = globalThis.crypto as (typeof globalThis.crypto | Awaited<ReturnType<typeof nodeCrypto>>)
+const crypto = globalThis.crypto as (typeof globalThis.crypto | typeof import('node:crypto'))
 
 /**
  * @returns A unique id

test/presets/classic.test.ts

@@ -1,4 +1,4 @@
-import { describe, expect, it } from '@jest/globals'
+import { afterEach, beforeEach, describe, expect, it } from '@jest/globals'
 
 import { mockCryptoFromArray, resetCrypto } from '../mocks/crypto'
 
@@ -39,7 +39,7 @@ describe('ClassicPreset', () => {
       node.addInput('a', input)
 
       expect(node.hasInput('a')).toBeTruthy()
-      expect(node.inputs['a']).toBe(input)
+      expect(node.inputs.a).toBe(input)
     })
 
     it('throws error if Input already exists', () => {
@@ -66,7 +66,7 @@ describe('ClassicPreset', () => {
       node.addOutput('a', output)
 
       expect(node.hasOutput('a')).toBeTruthy()
-      expect(node.outputs['a']).toBe(output)
+      expect(node.outputs.a).toBe(output)
     })
 
     it('throws error if Output already exists', () => {

test/scope.test.ts

@@ -72,7 +72,7 @@ describe('Scope', () => {
       expect(pipe).toHaveBeenCalledWith({ parent: 'test' })
     })
 
-    it('should return a promise from emit', async () => {
+    it('should return a promise from emit', () => {
       const scope = new Scope<Parent>('test')
       const signal = jest.fn<() => Parent>()
 

test/utils.test.ts

@@ -1,4 +1,4 @@
-import { describe, expect, it, jest } from '@jest/globals'
+import { afterEach, beforeEach, describe, expect, it, jest } from '@jest/globals'
 import { Buffer } from 'buffer'
 
 import { mockCryptoFromArray, mockCryptoFromBuffer, resetCrypto } from './mocks/crypto'

tsconfig.json

@@ -1,11 +1,12 @@
 {
+    "extends": "rete-cli/configs/tsconfig.json",
     "compilerOptions": {
         "target": "es5",
         "downlevelIteration": true,
 	    "isolatedModules": false,
+        "strict": true,
         "skipLibCheck": true,
         "lib": []
-
     },
-    "include": ["src"]
+    "include": ["src", "test"]
 }