SCT-156 Build: ErrorHandlerMiddleware pattern in Bean framework #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaoweiqiao-tre
changed the title
gaoweiqiao-tre
requested review from
SunJinping-TRE-C,
tanvir-retailai and
yu-yk
yu-yk
suggested changes
Jan 11, 2022
internal/project/framework/bean.go
Outdated
Comment on lines
31
to
35
| errorHandlerMiddlewares := concatErrorHandlerMiddlewares(b.errorHandlerMiddlewares, | ||
| berror.ValidationErrorHanderMiddleware, | ||
| berror.APIErrorHanderMiddleware, | ||
| berror.HTTPErrorHanderMiddleware, | ||
| berror.DefaultErrorHanderMiddleware) |
There was a problem hiding this comment.
we can also use
b.UseErrorHandlerMiddleware(berror.ValidationErrorHanderMiddleware)
b.UseErrorHandlerMiddleware(berror.APIErrorHanderMiddleware)
...
then we don't need the concat function, right?
There was a problem hiding this comment.
we can also use
b.UseErrorHandlerMiddleware(berror.ValidationErrorHanderMiddleware) b.UseErrorHandlerMiddleware(berror.APIErrorHanderMiddleware) ...then we don't need the concat function, right?
yes, but it make user don't need to think about framework errorHandlers, and it make less code in main.go
yu-yk
reviewed
Jan 11, 2022
internal/project/framework/bean.go
Outdated
Comment on lines
68
to
70
| for _, m := range frameworkMiddlewares { | ||
| middlewares = append(middlewares, m) | ||
| } |
There was a problem hiding this comment.
Suggested change
| for _, m := range frameworkMiddlewares { | |
| middlewares = append(middlewares, m) | |
| } | |
| middlewares = append(middlewares, frameworkMiddlewares...) |
yu-yk
approved these changes
Jan 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
error_middleware_test.go