fix: carry over context to span with parent span #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatsuoTakuro
requested review from
tanvir-retailai,
ZhaoYuRetailAI and
zhongdalu-trechina
| @@ -47,13 +47,7 @@ func StartSpan(c context.Context, operation string, spanOpts ...sentry.SpanOptio | |||
| spanOpts = append(spanOpts, sentry.WithDescription(functionName)) | |||
| } | |||
|
|
|||
| parent := sentry.SpanFromContext(c) | |||
There was a problem hiding this comment.
@MatsuoTakuro the parent does not obtain other context value except spanContextKey{}. that's the reason right?
There was a problem hiding this comment.
Yes, other context values like timeout deadline except a chain of spans weren't carried over when the context included a parent span.
Accordingly, I fixed the title for this PR.
MatsuoTakuro
changed the title
tanvir-retailai
deleted the
fix/set-exsting-ctx-even-without-parent-span
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.