Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine Luhn Number Generator #210

Merged
merged 2 commits into from
Sep 18, 2024
Merged

Refine Luhn Number Generator #210

merged 2 commits into from
Sep 18, 2024

Conversation

MatsuoTakuro
Copy link
Collaborator

@MatsuoTakuro MatsuoTakuro commented Sep 18, 2024 •
edited
Loading

  • Add some constraint logics related to length of input for number generator.
  • Use rand.Intn(10) instead of rand.New(src Source) and r.Intn(9).
    • To include 9 cuz n value cannot be generated in random way by the Intn func.
    • For more performance and still concurrent safe way.
  • Use testify in testing for more ease of writing and readability.

@tanvir-retailai tanvir-retailai merged commit a828da2 into develop Sep 18, 2024
1 check passed
@tanvir-retailai tanvir-retailai deleted the feat/refine-luhn-number-generator branch September 18, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanvir-retailai tanvir-retailai Awaiting requested review from tanvir-retailai tanvir-retailai is a code owner

@zhongdalu-trechina zhongdalu-trechina Awaiting requested review from zhongdalu-trechina zhongdalu-trechina is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MatsuoTakuro @tanvir-retailai