Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Graceful Shutdown to ServeAt method #196

Merged
merged 3 commits into from
Jul 17, 2024
Merged

feat: Add Graceful Shutdown to ServeAt method #196

merged 3 commits into from
Jul 17, 2024

Conversation

MatsuoTakuro
Copy link
Collaborator

@MatsuoTakuro MatsuoTakuro commented Jul 3, 2024 •
edited
Loading

  • Make ServeAt return an error so that handling the error is left to bean user side.
  • Add ShutdownTimeout (30s by default) to bean.Config

@MatsuoTakuro MatsuoTakuro marked this pull request as ready for review July 3, 2024 08:43
@tanvir-retailai
Copy link
Contributor

@MatsuoTakuro Need to add ShutdownTimeout config into the env.json template.

@zhongdalu-trechina zhongdalu-trechina self-requested a review July 4, 2024 06:29
@tanvir-retailai tanvir-retailai merged commit d20f4e4 into develop Jul 17, 2024
1 check passed
@tanvir-retailai tanvir-retailai deleted the feat/add-graceful-shutdown branch July 17, 2024 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhongdalu-trechina zhongdalu-trechina zhongdalu-trechina approved these changes

@tanvir-retailai tanvir-retailai Awaiting requested review from tanvir-retailai tanvir-retailai is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MatsuoTakuro @tanvir-retailai @zhongdalu-trechina