Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: destroyed async/await handler #1937

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

misyuari
Copy link

@misyuari misyuari commented Dec 16, 2022

Pre-Submission Checklist

  • Opened an issue discussing these changes before opening the PR
  • Ran the linter and tests via make prepush
  • Included comprehensive and convincing tests for changes

Issues

Closes:

Changes

Fix unstopped chain-handler when response already destroyed.

@gmahomarf
Copy link

I'm not sure how this fixes #1935. The issue there is that one is no longer allowed to have async handlers which also call next, due to handler arity checks.

@misyuari
Copy link
Author

misyuari commented Feb 5, 2023

I'm not sure how this fixes #1935. The issue there is that one is no longer allowed to have async handlers which also call next, due to handler arity checks.

oh that was my fault, looks like it's a different issue, I've created a new issue

@ghermeto ghermeto self-requested a review February 15, 2023 18:05
Copy link
Member

@ghermeto ghermeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add tests?

@misyuari
Copy link
Author

can you add tests?

done, test added

…troyed-async-await-handler

# Conflicts:
#	test/server.test.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants