Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugins serveStatic fixes #1913

Open
wants to merge 8 commits into
base: 8.x
Choose a base branch
from
Open

Plugins serveStatic fixes #1913

wants to merge 8 commits into from

Conversation

kolbma
Copy link

@kolbma kolbma commented May 26, 2022

Pre-Submission Checklist

  • Opened an issue discussing these changes before opening the PR
  • Ran the linter and tests via make prepush
  • Included comprehensive and convincing tests for changes

Issues

Closes:

Well the most important is the directory traversal from #1910.
And because of there are the other related problems in the serveStatic plugin,
I've combined the stuff.

Changes

There should be no dependency on the dirname for specific path.
Introduced BadRequestErrors for problems on bad paths like urlencoded null bytes.
Added tests to check for traversals.
Reworked existing tests for making more sense.
Remove 2 doubled tests.
lints and style of bodyReader.test fixed to get prepush to run

kolbma and others added 8 commits May 25, 2022 18:57
@kolbma
fix(test): lints and style of bodyReader.test
e53c58b
@kolbma
chore(tests): remove 2 doubled tests
5371b40 
The 2 tests are already available at line 230.
@kolbma
fix(restifyGH-1910): plugins.serverStatic path traversal
93909da 
Fixes restify#1910
Added tests to check for traversals.
Reworked existing tests for making more sense.
@kolbma
fix(restifyGH-1864): plugins.serveStatic null byte crash
d7f32ea 
Fixes restify#1864
and propable some other BadRequest types.
@kolbma
fix(restifyGH-1604): plugins.serveStatic no dep dirname
c85da14 
Fixes restify#1604
There should be no dependency on the dirname for specific path.
@kolbma
fix(restifyGH-1864): plugins.serveStatic crash in Gzip
1180bb8 
This is also to be handled for Gzip content.
Fixes restify#1864
@kolbma
Merge pull request #1 from kolbma/restifyGH-1864
02c1497 
plugins.serveStatic Fixes restifyGH-1864/restifyGH-1910
@kolbma
Merge pull request #2 from kolbma/restifyGH-1604
7f36ae1 
plugins.serveStatic Fixes restifyGH-1604
@kolbma kolbma changed the title Plugins serve static fixes Plugins serveStatic fixes May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kolbma