Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove regular status printing for non terminals #974

Merged
merged 2 commits into from
May 25, 2017

Conversation

fd0
Copy link
Member

@fd0 fd0 commented May 25, 2017

No description provided.

@codecov
Copy link

codecov bot commented May 25, 2017

Codecov Report

Merging #974 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #974      +/-   ##
==========================================
- Coverage   53.69%   53.67%   -0.03%     
==========================================
  Files         110      110              
  Lines       10218    10223       +5     
==========================================
  Hits         5487     5487              
- Misses       4093     4098       +5     
  Partials      638      638
Impacted Files Coverage Δ
restic/progress.go 9.75% <0%> (-0.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37b107b...317d9c4. Read the comment docs.

@fd0 fd0 merged commit 317d9c4 into master May 25, 2017
fd0 added a commit that referenced this pull request May 25, 2017
Remove regular status printing for non terminals
@fd0 fd0 deleted the remove-noninteractive-progress branch May 25, 2017 16:57
@dirk777
Copy link

dirk777 commented Jul 14, 2017

Is there any chance to activate the progress report for windows when running in background?

@fd0
Copy link
Member Author

fd0 commented Jul 14, 2017

Nop, nothing built in. As far as I know, Windows doesn't have signals (in the Unix sense). Sorry.

@digitallyserviced
Copy link

I believe restic needs an actual logging facility that is not just a transient output to stdout or stderr and can be referenced without needing to just redirect these or turn on debug.

Making this structured we can include information about the files, the progress and other information if necessary that can be read/parsed later without having to invoke restic (file, influxdb, etc).

@dirk777
Copy link

dirk777 commented Jul 14, 2017

I highly appreciate this approach. This would improve restic' usability and makes it more developer friendly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants