Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compact cluster status #2714

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

muhamadazmy
Copy link
Contributor

@muhamadazmy muhamadazmy commented Feb 12, 2025

Compact cluster status

Summary:
Print out a compact cluster status by default

Extended view of the cluster status can still be accessed
via the --extra flag

There are also some minor fixes to the restatectl because of conflicting short flags across different commands.


Stack created with Sapling. Best reviewed with ReviewStack.

@muhamadazmy
Copy link
Contributor Author

muhamadazmy commented Feb 12, 2025

This is how it looks like atm.

image

image

image

@muhamadazmy muhamadazmy force-pushed the pr2714 branch 2 times, most recently from 9f03df3 to 3fe3dd3 Compare February 12, 2025 17:02
@muhamadazmy muhamadazmy marked this pull request as ready for review February 12, 2025 17:02
@AhmedSoliman
Copy link
Contributor

Not a fan of the letter-per-role approach. Perhaps the proposal is too compact? I can't quickly understand most of the columns.

@muhamadazmy
Copy link
Contributor Author

@AhmedSoliman I tried to use the full form but to me it looks like a lot of data in one column. But maybe you are right about being too compact. Probably better to split the PARTITIONS into LEADERS, FOLLOWERS and the NODESETS to NODESETS and SEQUNCERS

@pcholakov
Copy link
Contributor

This is definitely more readable; did we give up on trying to convey the sequencer-partition leader colocation status?

I would consider using singular 'LEADERorFOLLOWERheadings. The way to read the table is something like "node N is a leader for X partitions".NODESETSsounds a bit awkward but the best alternative I can offer is something longer likeNODESET-MEMBER` (in my head, that reads as "node N is a nodeset member of Y nodesets / serves Y log tail segments").

Summary:
- Support parsing an "range" input.
- Handle id range in some common operations
  - `logs describe`
  - `logs find-tail`
  - `logs reconfigure`
  - `snapshots create-snapshot`
Summary:
Print out a compact cluster status by default

Extended view of the cluster status can still be accessed
via the `--extra` flag


> There are also some minor fixes to the restatectl because of conflicting short flags across different commands.
@muhamadazmy
Copy link
Contributor Author

@pcholakov the sequence/partition colocation status is only denoted by the colour so far. The green on the sequencer status means it's optimal colocation, if yellow then it's not. But this might be confusing if colours are not enabled

@pcholakov
Copy link
Contributor

That's perfect, I think colour is okay as this is a relatively advanced concept.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants