Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote sequencer now handle cancelled/gone sequencers #2676

Merged
merged 2 commits into from
Feb 10, 2025
Merged

Conversation

Copy link

github-actions bot commented Feb 8, 2025

Test Results

  7 files  ±0    7 suites  ±0   3m 25s ⏱️ -52s
 45 tests  - 2   44 ✅  - 2  1 💤 ±0  0 ❌ ±0 
174 runs   - 8  171 ✅  - 8  3 💤 ±0  0 ❌ ±0 

Results for commit fa53908. ± Comparison against base commit bb09c3d.

This pull request removes 2 tests.
dev.restate.sdktesting.tests.AwaitTimeout ‑ timeout(Client)
dev.restate.sdktesting.tests.RawHandler ‑ rawHandler(Client)

♻️ This comment has been updated with latest results.

Copy link
Contributor

@tillrohrmann tillrohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding support for handling cancelled/gone sequencers @AhmedSoliman. The changes look good to me. I left two clarifying questions. +1 for merging.

This also adds a little bit more stress to the tests to help them fail more often if there is an issue

```
// intentionally empty
```
@AhmedSoliman AhmedSoliman merged commit 98dda30 into main Feb 10, 2025
10 checks passed
@AhmedSoliman AhmedSoliman deleted the pr2676 branch February 10, 2025 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants