-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remote sequencer now handle cancelled/gone sequencers #2676
Conversation
Test Results 7 files ±0 7 suites ±0 3m 25s ⏱️ -52s Results for commit fa53908. ± Comparison against base commit bb09c3d. This pull request removes 2 tests.
♻️ This comment has been updated with latest results. |
9f0406e
to
6b56d74
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding support for handling cancelled/gone sequencers @AhmedSoliman. The changes look good to me. I left two clarifying questions. +1 for merging.
This also adds a little bit more stress to the tests to help them fail more often if there is an issue ``` // intentionally empty ```
This also adds a little bit more stress to the tests to help them fail more often if there is an issue
Stack created with Sapling. Best reviewed with ReviewStack.