Try to campaign when starting and being a voter #2657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AhmedSoliman
approved these changes
Feb 7, 2025
This commit changes the LogsController::find_logs_tail operation to run the find_tail operations per log concurrently instead of sequentially.
Instead we are printing only the PlainNodeId until we better know whether we want to show the full MemberId.
This commit generifies the LogStoreMarker by moving it to restate-types, renaming it into StorageMarker and making the id generic.
This commit uses the common StorageMarker to mark the RaftMetadataServer's storage as initialized. The created_at timestamp will be used to identify a RaftMetadataServer member uniquely across join attempts and to detect if we lost the disk.
Before we stored the NodesConfiguration when running as a StandBy. However, by the time we try to join, it might have changed so that we wouldn't reconstruct the same state when restarting. This is now fixed.
It now logs the configuration when it applies/restores a new configuration.
In order to avoid the delay of an election timeout when restarting a RaftMetadataServer, they try to campaing immediately if they are part of the current configuration as voters. This won't disturb an existing leader because we have pre-vote enabled.
tillrohrmann
force-pushed
the
metadata-store-improvements
branch
from
5b2b055 to
c8f10ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to avoid the delay of an election timeout when restarting a RaftMetadataServer,
they try to campaign immediately if they are part of the current configuration as voters.
This won't disturb an existing leader because we have pre-vote enabled.