[Bifrost] Allow top-level find_tail to auto-retry #2649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 6, 2025
AhmedSoliman
force-pushed
the
pr2649
branch
2 times, most recently
from
91b9130 to
bc16992
Compare
Test Results 7 files ±0 7 suites ±0 2m 43s ⏱️ -52s Results for commit bc16992. ± Comparison against base commit d730f92. This pull request removes 2 and adds 2 tests. Note that renamed tests count towards both. |
This was referenced Feb 6, 2025
tillrohrmann
approved these changes
Feb 6, 2025
crates/bifrost/src/error.rs
Outdated
Comment on lines
28
to
29
| // #[error("log '{0}' is sealed")] | ||
| // LogSealed(LogId), |
Previously, setting target nodeset size with restatectl would tell you that "No change" ``` // intentionally empty ```
The PR also uses it in CheckSeal. This utility `DecoratedNodeSet` can be used when you want to add a nugget of information next to every node. It prints the nodeset sorted as well. ``` // intentionally empty ```
Key changes: - Using JoinSet instead of unordered futures to perform store tasks to avoid some of its tricky lockup scenarios - Store tasks are free to use whatever connection is available, this over-indexes over the current design that serializes all writes in a one-at-a-time fashion, but removes a lock, and simplifies the logic. - Extra in-flight stores are aborted after an append is complete to avoid overloading - Timeout store tasks only on the basis of their network operation and not on the time they're waiting for the tail to move - Cache nodeset checker across waves - Better logging on failures, it reports the nodeset status with the number of attempts per node - Adds a new metric to latency of appends Performance testing shows no regression and reliability testing appears to show no regression even in tricky failure scenarios. ``` // intentionally empty ```
Those find_tail operations are only used by the partition_processor on startup and we don't want it to fail unnecessarily, this gives it a good chance to succeed unless the underlying error is not retryable. ``` // intentionally empty ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those find_tail operations are only used by the partition_processor on startup and we don't want it to fail unnecessarily, this gives it a good chance to succeed unless the underlying error is not retryable.
Stack created with Sapling. Best reviewed with ReviewStack.
DecoratedNodeSetUtility to display decorated nodesets #2646