Fix configuration compatibility issues #2648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muhamadazmy
commented
Feb 6, 2025
| #[serde(flatten)] | ||
| pub kind: MetadataServerKind, | ||
| kind: Option<MetadataServerKind>, |
There was a problem hiding this comment.
The weird thing I found is that even with [serde(default)] the decoder still complains about missing key type.
Merged
muhamadazmy
force-pushed
the
pr2648
branch
3 times, most recently
from
26237a1 to
04ef4ef
Compare
pcholakov
approved these changes
Feb 6, 2025
Summary: Making sure a single node server v1.2 can still work with a v1.1.6 config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix configuration compatibility issues
Summary:
Making sure a single node server v1.2 can still work
with a v1.1.6 config
Stack created with Sapling. Best reviewed with ReviewStack.