Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restatectl unification #2634

Merged
merged 4 commits into from
Feb 5, 2025
Merged

Restatectl unification #2634

merged 4 commits into from
Feb 5, 2025

Conversation

jackkleeman
Copy link
Contributor

@jackkleeman jackkleeman commented Feb 5, 2025

This PR reduces release build time of restatectl when restate-server build is cached from 9 minutes to 3 minutes, via various otherwise-generally-sensible changes:

  1. Don't include datafusion in restatectl, by making storage query a feature of restate-admin
  2. Set the "profiling" feature on jemalloc-sys always, not just in server, as otherwise we have to rebuild jemalloc-sys and rocksdb-sys for restatectl
  3. Disallow jsonschema from making outbound http/file requests, which means it doesn't need the reqwest 'blocking' feature, which differed from other binaries. This is also probably a security catch cc @slinkydeveloper

NB: in CI builds, we are currently unifying all features anyway, although we need to change this. So, unifying a little bit in our Cargo.toml just lessens the impact of ununifying everything in CI.

Copy link

github-actions bot commented Feb 5, 2025

Test Results

  7 files  ±0    7 suites  ±0   4m 29s ⏱️ +7s
 47 tests ±0   46 ✅ ±0  1 💤 ±0  0 ❌ ±0 
182 runs  ±0  179 ✅ ±0  3 💤 ±0  0 ❌ ±0 

Results for commit 93596e1. ± Comparison against base commit 435241e.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@AhmedSoliman AhmedSoliman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. Great job @jackkleeman

@jackkleeman jackkleeman merged commit f7b1e5a into main Feb 5, 2025
28 checks passed
@jackkleeman jackkleeman deleted the restatectl-unification branch February 5, 2025 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants