Health in TaskCenter #2613
Closed
Health in TaskCenter #2613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 3, 2025
Test Results 7 files ±0 7 suites ±0 3m 40s ⏱️ -48s Results for commit e407716. ± Comparison against base commit d641697. This pull request removes 2 tests.♻️ This comment has been updated with latest results. |
AhmedSoliman
force-pushed
the
pr2613
branch
2 times, most recently
from
7ff1daa to
30a66d5
Compare
tillrohrmann
approved these changes
Feb 4, 2025
crates/node/src/roles/base.rs
Outdated
| // We don't want this task to shutdown by task center, we intentionally want to leak it and | ||
| // leave it running until the runtime is terminated. | ||
| // | ||
| // This is because we want to try and response with NodeStatus::ShuttingDown for as long as |
There was a problem hiding this comment.
Suggested change
| // This is because we want to try and response with NodeStatus::ShuttingDown for as long as | |
| // This is because we want to respond while NodeStatus::ShuttingDown for as long as |
?
There was a problem hiding this comment.
This actually is old comment. will remove.
Comment on lines
+96
to
+97
| /// Cluster controller is the first thing that gets stopped when the server is shut down | ||
| ClusterController, |
There was a problem hiding this comment.
in the next PR.
Comment on lines
+62
to
+65
| self.inner | ||
| .health | ||
| .node_status() | ||
| .merge(NodeStatus::StartingUp); |
There was a problem hiding this comment.
The NodeStatus is spread across the code base with this change. But I guess w/o structured concurrency there is no way to keep it in fewer places.
AhmedSoliman
force-pushed
the
pr2613
branch
2 times, most recently
from
a8bbd8a to
a69c11a
Compare
AhmedSoliman
force-pushed
the
pr2613
branch
2 times, most recently
from
e6faa60 to
9876c9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack created with Sapling. Best reviewed with ReviewStack.