Skip to content

Commit

Permalink
[Bifrost] Allow repair stores on unsealed log-server
Browse files Browse the repository at this point in the history
This was overly/incorrectly protective. We'll see those errors when often because we only need to seal f-majority, subsequent tail repair operations on restarts should still succeed on this log-server. A future follow-up (was already planned) is to lazily seal the loglet once we observe this operation on this log-server, but I didn't think that doing it in this time frame is necessary.

```
// intentionally empty
```
  • Loading branch information
AhmedSoliman committed Feb 10, 2025
1 parent 22468ce commit f7b0d37
Showing 1 changed file with 1 addition and 12 deletions.
13 changes: 1 addition & 12 deletions crates/log-server/src/loglet_worker.rs
Original file line number Diff line number Diff line change
Expand Up @@ -385,22 +385,11 @@ impl<S: LogStore> LogletWorker<S> {
}

if body.flags.contains(StoreFlags::IgnoreSeal) {
// We must be sealed (sanity check)
// Accept repair store only on sealed loglet.
if !self.loglet_state.is_sealed() {
warn!(
loglet_id = %self.loglet_id,
%peer,
first_offset = %body.first_offset,
"Ignoring repair store on unsealed loglet, repair should only happen on sealed loglets"
);
return (Status::Malformed, None);
}
trace!(
loglet_id = %self.loglet_id,
%peer,
first_offset = %body.first_offset,
"Admitting a repair store for sealed loglet to restore replication"
"Admitting a repair store loglet to restore replication"
);
}

Expand Down

0 comments on commit f7b0d37

Please sign in to comment.