Propagate empty CF export as snapshot error

restatedev · Feb 13, 2025 · 46a53c4 · 46a53c4
1 parent 9194379
commit 46a53c4
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/crates/rocksdb/src/error.rs b/crates/rocksdb/src/error.rs
@@ -34,6 +34,9 @@ pub enum RocksError {
     #[error("invalid key range for partition")]
     #[code(unknown)]
     SnapshotKeyRangeMismatch,
+    #[error("export column family returned an empty set of SST files")]
+    #[code(unknown)]
+    SnapshotEmpty,
     #[error(transparent)]
     #[code(unknown)]
     Other(#[from] rocksdb::Error),

diff --git a/crates/rocksdb/src/lib.rs b/crates/rocksdb/src/lib.rs
@@ -431,6 +431,15 @@ impl RocksDb {
                     .export_column_family(&data_cf_handle, export_dir.as_path())
                     .map_err(RocksError::Other)?;
 
+                if metadata.get_files().is_empty() {
+                    warn!(
+                        "Refusing to create an empty snapshot! RocksDB column family export \
+                        returned an empty set of files. The export is retained at: {}",
+                        export_dir.display()
+                    );
+                    return Err(RocksError::SnapshotEmpty);
+                }
+
                 Ok(metadata)
             })
             .build()