Activate metadata-api only for internal CI builds

restatedev · Feb 7, 2025 · 0a4ff2a · 0a4ff2a
1 parent 8a8556d
commit 0a4ff2a
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 2 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -94,6 +94,7 @@ jobs:
     name: Create docker image
     uses: ./.github/workflows/docker.yml
     with:
+      features: 'metadata-api'
       uploadImageAsTarball: true
       platforms: linux/amd64
 

diff --git a/.github/workflows/docker-release.yml b/.github/workflows/docker-release.yml
@@ -20,6 +20,7 @@ jobs:
       pushToDockerHub: true
       parca: true
       buildIndividually: true
+      releaseBuild: true
 
   docker-cli:
     name: Push CLI Docker image

diff --git a/.github/workflows/docker.yml b/.github/workflows/docker.yml
@@ -33,6 +33,11 @@ on:
         required: false
         default: ""
         type: string
+      releaseBuild:
+        description: "prevent non-release features from being included in build"
+        required: false
+        default: false
+        type: boolean
       pushToDockerHub:
         description: "push image to DockerHub"
         required: false
@@ -166,6 +171,14 @@ jobs:
             type=semver,pattern={{version}}
             type=semver,pattern={{major}}.{{minor}}
 
+      - name: Check for non-release features in release builds
+        if: ${{ inputs.releaseBuild }}
+        run: |
+           if [[ "${{ inputs.features }}" =~ "metadata-api" ]]; then
+             echo "Release builds should not contain non-release only features: ${{ inputs.features }}"
+             exit 1
+           fi
+
       - name: Build${{(inputs.uploadImageAsTarball != true || github.ref == 'refs/heads/main') && ' and push ' || ' '}}Docker image
         id: build
         uses: docker/build-push-action@v6
@@ -186,7 +199,7 @@ jobs:
             CARGO_PROFILE_RELEASE_DEBUG=${{ inputs.debug || inputs.parca }}
             BUILD_INDIVIDUALLY=${{ inputs.buildIndividually }}
             UPLOAD_DEBUGINFO=${{ inputs.parca }}
-            RESTATE_FEATURES=${{ inputs.features || '' }}
+            RESTATE_FEATURES=${{ inputs.features || releaseBuild && '' || 'metadata-api' }}
           secrets: |
             parca=${{ secrets.PARCA_TOKEN }}
           cache-from: type=gha,url=http://127.0.0.1:49160/

diff --git a/crates/admin/Cargo.toml b/crates/admin/Cargo.toml
@@ -8,7 +8,7 @@ license.workspace = true
 publish = false
 
 [features]
-default = ["replicated-loglet", "serve-web-ui", "metadata-api"]
+default = ["replicated-loglet", "serve-web-ui"]
 clients = []
 options_schema = ["restate-service-client/options_schema"]
 memory-loglet = ["restate-bifrost/memory-loglet"]