Download the template from the examples repo #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slinkydeveloper
force-pushed
the
issues/22
branch
from
69e76c9 to
1f43a87
Compare
gvdongen
approved these changes
Apr 23, 2024
There was a problem hiding this comment.
Looks good to me but we also need to update the comments in the template itself: https://github.com/restatedev/examples/blob/dev_0.9/templates/typescript/src/app.ts
Or make sure they don't have code in them because they are constantly outdated....
It should just refer to the quickstart actually. Should I pick this up? |
Co-authored-by: Giselle van Dongen <giselle.vd@gmail.com>
That would be great. Perhaps the same should be done for java and kotlin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #22
Also updated eslint to use 9.x, bumped minimum node version (for fetch)