Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dynamically set Violet Rails Root #2

Open
donrestarone opened this issue Jun 26, 2022 · 0 comments
Open

dynamically set Violet Rails Root #2

donrestarone opened this issue Jun 26, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@donrestarone
Copy link
Contributor

donrestarone commented Jun 26, 2022 •
edited
Loading

currently its hard coded to violet.restarone.solutions -- we need to make it flexible so we can build apps for any Violet Rails endpoint.

requirements

  1. Define the VioletRailsAppRoot variable once and use it throughout the app. This variable should be clear and easy to change for engineers forking this repository to build a Violet Rails iOS app a different Violet Rails web app. (eg: using this same code base to launch an app that connects to restarone.com instead of violet.restarone.solutions)
  2. Retain the hard-coded bottom nav links (home, blog, forum), but extract it to a variable, reuse it throughout the app and allow it to be easily changed. (eg: adding another tab/changing the tabs should be easy as changing this variable).
@donrestarone donrestarone added the enhancement New feature or request label Mar 30, 2023
@donrestarone donrestarone mentioned this issue Apr 1, 2023
Merged
donrestarone pushed a commit that referenced this issue Apr 1, 2023
@josessolmaximo
[feature] dynamically set Violet Rails Root (#15)
c423039 
Addresses: #2

Added variables to store root url and tabs.

Edit the URL in `ENDPOINT` to point to a different website.
<img width="582" alt="image" src="https://user-images.githubusercontent.com/112497883/229297052-539f31cd-1481-488b-823d-24fcb9e1a931.png">

You can customize the tab navigation by removing, editing or adding `NavigationTab` to `navigationTabs` array.
<img width="626" alt="image" src="https://user-images.githubusercontent.com/112497883/229155259-7cc356cb-0dfe-474d-ad65-2fcb83e96da8.png">
@donrestarone donrestarone mentioned this issue Apr 1, 2023
Merged
donrestarone added a commit that referenced this issue Apr 1, 2023
@donrestarone @josessolmaximo
[feature] dynamically set Violet Rails Root (#15) (#16)
9fca48a 
Addresses: #2

Added variables to store root url and tabs.

Edit the URL in `ENDPOINT` to point to a different website.
<img width="582" alt="image" src="https://user-images.githubusercontent.com/112497883/229297052-539f31cd-1481-488b-823d-24fcb9e1a931.png">

You can customize the tab navigation by removing, editing or adding `NavigationTab` to `navigationTabs` array.
<img width="626" alt="image" src="https://user-images.githubusercontent.com/112497883/229155259-7cc356cb-0dfe-474d-ad65-2fcb83e96da8.png">

Co-authored-by: josessolmaximo <112497883+josessolmaximo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@donrestarone