[bugfix] dynamic property render in snippets #1364
Conversation
… into bugfix/dynamic_property_render
[bugfix] dynamic property render in snippets
|
Deployed review-app can be viewed at https://review-1364.violet-test.net |
|
@ajaystha42 did you test your code? The generated template renders nothing because it scopes by all attributes:
|
|
Deployed review-app can be viewed at https://review-1364.violet-test.net |
@donrestarone , it looks like the scoping fails for an array only. I will fix it! |
… into ajaystha42bugfix/dynamic_property_render
|
review this PR in the CMS: restarone/comfortable-mexican-sofa#12 |
Gemfile.lock
Outdated
| @@ -577,4 +577,4 @@ RUBY VERSION | |||
| ruby 3.0.0p0 | |||
|
|
|||
| BUNDLED WITH | |||
| 2.1.4 | |||
| 2.1.4 | |||
There was a problem hiding this comment.
please remove this change
|
@ajaystha42 could you add a test to verify that the correct snippet is rendered? |
… into ajaystha42bugfix/dynamic_property_render
…-ajaystha42:restarone/violet_rails into ajaystha42bugfix/dynamic_property_render
sthajay
force-pushed
the
ajaystha42bugfix/dynamic_property_render
branch
from
7287be3 to
989b9a7
Compare
|
Deployed review-app can be viewed at https://review-1364.violet-test.net |
|
copy pasting snippet is still not working, we need to verify that the generated snippet works out of the box
@Ayon95 could you take a look? This issue is affecting sipshucksip.com |
|
@donrestarone The index snippet is working now. The snippet that was being used was not right. Can you create some resources for https://review-1364.violet-test.net/tester
|
|
@donrestarone Please review this PR. I will point to the cms/restarone once you merge it in the main repo from the forked repo. Also, here is the video to demonstrate the working of dynamic snippets: Screen.Recording.2023-02-19.at.23.05.15.mov |
|
@ajaystha42 there are 2 PR's of yours that do the same thing on https://github.com/restarone/comfortable-mexican-sofa/pulls this PR is using the branch here: restarone/comfortable-mexican-sofa#13 and as I have mentioned before, the default generated snippet is not working. Lets revisit this with fresh eyes later |
… into ajaystha42bugfix/dynamic_property_render
|
Deployed review-app can be viewed at https://review-1364.violet-test.net |
|
Deployed review-app can be viewed at https://review-1364.violet-test.net |
|
@donrestarone The snippets are working now: Please have a look here: https://review-1364.violet-test.net/test-page |
donrestarone
added
Passing UAT on Testnet ✅
and removed
Failing UAT ❌ ☠️
do not merge
labels
|
Deployed review-app can be viewed at https://review-1364.violet-test.net |
|
LGTM on the review app, deploying RC ✅ After release candidate is verified, we can merge restarone/comfortable-mexican-sofa#16, bump the version on the CMS and change to the latest version before merging to master |
Addresses: #1355
Demo:
Screen.Recording.2023-02-19.at.23.05.15.mov