Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve illegal character error in rimraf #858

Conversation

codewithmitesh
Copy link
Contributor

✨ Pull Request

📓 Referenced Issue

Fixes: #849

ℹ️ About the PR

Updated rimraf to a suitable version and used the --glob flag to resolve the illegal character error that was preventing the command from running properly.

Changes the rimraf version from 4.1.2 to 4.2.0 also attached --glob flag to allow wildcards in path
As per :- isaacs/rimraf#249

🖼️ Testing Scenarios / Screenshots

Before :

Issue-Reponsively-Bug

After :

 
Issue-Reponsively-Bug

Updated rimraf to a suitable version and used the --glob flag to resolve the illegal character error that was preventing the command from running properly.

Fixes: responsively-org#849
Copy link
Collaborator

@manojVivek manojVivek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is soo awesome, it's been a long pending debt! Thanks for fixing this! ❤️

Looking forward to more like this!

@manojVivek manojVivek merged commit 751d3fa into responsively-org:main Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rimraf unable to run command with special character( Windows OS )🤯
2 participants