Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selecting the url in searchbar when clicked first #1275

Merged

Conversation

Pulkitxm
Copy link
Contributor

@Pulkitxm Pulkitxm commented Aug 6, 2024

✨ Pull Request

📓 Referenced Issue

#1272

ℹ️ About the PR

This pull request addresses the issue where clicking on the search bar in the Responsively App only places the cursor at the clicked position instead of selecting the entire URL. The update ensures that clicking the search bar will now select the entire URL.

🖼️ Testing Scenarios / Screenshots

preview.mp4

@CLAassistant
Copy link

CLAassistant commented Aug 6, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@violetadev violetadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I tested it on mac and it works well! gj

@violetadev violetadev merged commit b9f5159 into responsively-org:main Aug 6, 2024
4 checks passed
@manojVivek
Copy link
Collaborator

Amazing!

@all-contributors Please add @Pulkitxm for code.

Copy link
Contributor

@manojVivek

I've put up a pull request to add @Pulkitxm! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants